Target hostapp hook: Only patch should_be_operated_by__release if null or older release #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cywang117
force-pushed
the
hostapp-hook-only-patch-operated-by-if-null
branch
3 times, most recently
from
5b83d46 to
7115ace
Compare
cywang117
changed the title
…l or older release With Supervisor managed HUP, we'll soon start relying on should_be_operated_by__release to determine the target hostapp release. The Supervisor reports os_version and os_variant on device provision, and the current target-hostapp hook will set the should_be_operated_by field when receiving that initial state report. However, SV manage HUP means this field could be set prior to device provision, so we don't want to overwrite it if it's not null. If the should_be_operated_by field has a release that's older than the reported OS release though, we should update the field to the reported OS release. Change-type: patch Signed-off-by: Christina Ying Wang <[email protected]>
cywang117
force-pushed
the
hostapp-hook-only-patch-operated-by-if-null
branch
from
7115ace to
2bde660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Supervisor managed HUP, we'll soon start relying on
should_be_operated_by__releaseto determine the target hostapp release. A change to this field will trigger the device update hook for the Supervisor to pick up and trigger HUP.The Supervisor reports
os_versionandos_varianton device provision, and the current target hostapp hook will set this field when receiving that current state report. However, SV manage HUP means this field could be set prior to device provision, so we don't want to overwrite it if it's not null.Also, if the
should_be_operated_byfield has a release that's older than the reported OS releasethough, we should update the field to the reported OS release.
Change-type: patch